This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Stop animation on detached #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, this is still not enough to stop streetview pano events from spawning and destroying parent elements. I'm looking into this further.
|
|
Here is a screenshot showing what happens in the dom when the browser tab is active and this element creates and destroys yp-group in an endless loop.
|
|
Good news! I was having some bower issues and was actually not running this latest code. This PR does fully resolve the problem so it should be good to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the animation callbacks will get top level elements into endless attached/detached loops.